From 71a22c6a121d1294a05ef35020c525fa70cae2fd Mon Sep 17 00:00:00 2001 From: Brianna Rainey Date: Thu, 29 Jan 2026 14:50:29 -0500 Subject: v2.2.2 - fix flaky tests, fix UnboundLocalError in MainWindow.createNewProject (#94) * search more than one filename for compName * remove extra QVBoxLayout * insert default components using name instead of index * bump version 2.2.1 to 2.2.2 * tests do not use `.config` for settings Core.storeSettings() is no longer called as a side effect any time avp.core is imported. Thus the tests use a new `initCore` method and the normal user path now relies on entering via `cli.py`. This means certain toolkit functions (e.g., ones using `FFMPEG_BIN`) no longer work if imported from a different python script, unless they call Core.storeSettings() themselves to initialize the settings.ini file * fix UnboundLocalError in createNewProject--- tests/test_toolkit_common.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'tests/test_toolkit_common.py') diff --git a/tests/test_toolkit_common.py b/tests/test_toolkit_common.py index 8e9dca2..b20ae53 100644 --- a/tests/test_toolkit_common.py +++ b/tests/test_toolkit_common.py @@ -2,20 +2,25 @@ from pytest import fixture from pytestqt import qtbot from avp.command import Command from avp.toolkit import blockSignals, rgbFromString +from . import command @fixture def gotWarning(): """Check if a function called log.warning""" import avp.toolkit.common as tk + warning = False + def gotWarning(): nonlocal warning return warning + class log: def warning(self, *args): nonlocal warning warning = True + oldLog = tk.log tk.log = log() try: @@ -24,8 +29,7 @@ def gotWarning(): tk.log = oldLog -def test_blockSignals(qtbot): - command = Command() +def test_blockSignals(qtbot, command): command.core.insertComponent(0, 0, command) comp = command.core.selectedComponents[0] assert comp.page.spinBox_scale.signalsBlocked() == False @@ -41,4 +45,4 @@ def test_rgbFromString(gotWarning): def test_rgbFromString_error(gotWarning): assert rgbFromString("255,255,256") == (255, 255, 255) - assert gotWarning() \ No newline at end of file + assert gotWarning() -- cgit v1.2.3